Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: v3.0.0 #1233

Merged
merged 71 commits into from
Aug 30, 2024
Merged

Feature: v3.0.0 #1233

merged 71 commits into from
Aug 30, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 22, 2024

Fixes: #715

Fixes: #937

Fixes: #1275

@emmercm emmercm self-assigned this Jul 22, 2024
@maxexcloo
Copy link
Contributor

Looking absolutely awesome man! Every time I open GitHub I see your project and it keeps getting better 👌

@emmercm
Copy link
Owner Author

emmercm commented Aug 2, 2024

Thank you @maxexcloo! Progress has been good on these major features. I've been doing a lot of testing with my own collection, trying to get this ready for release soon!

@emmercm emmercm marked this pull request as ready for review August 30, 2024 23:13
@emmercm emmercm enabled auto-merge August 30, 2024 23:26
@emmercm emmercm merged commit 79093af into main Aug 30, 2024
59 of 60 checks passed
@emmercm emmercm deleted the emmercm/3.0.0-feature branch August 30, 2024 23:30
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 89.20188% with 161 lines in your changes missing coverage. Please review.

Project coverage is 92.60%. Comparing base (fcf0793) to head (7c15428).
Report is 72 commits behind head on main.

Files with missing lines Patch % Lines
src/console/progressBarCli.ts 75.71% 14 Missing and 3 partials ⚠️
src/types/files/fileCache.ts 64.44% 15 Missing and 1 partial ⚠️
src/types/files/archives/chd/chdBinCueParser.ts 77.04% 14 Missing ⚠️
src/types/indexedFiles.ts 77.27% 10 Missing ⚠️
src/modules/candidateWriter.ts 83.33% 8 Missing and 1 partial ⚠️
src/types/files/archives/chd/chd.ts 88.75% 9 Missing ⚠️
src/igir.ts 93.06% 7 Missing ⚠️
src/types/files/archives/chd/chdGdiParser.ts 77.41% 7 Missing ⚠️
src/types/files/file.ts 0.00% 7 Missing ⚠️
src/modules/datScanner.ts 80.64% 6 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   93.22%   92.60%   -0.63%     
==========================================
  Files         108      118      +10     
  Lines        6745     7473     +728     
  Branches     1483     1820     +337     
==========================================
+ Hits         6288     6920     +632     
- Misses        456      528      +72     
- Partials        1       25      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

@maxexcloo
Copy link
Contributor

Congrats on the release! Looking forward to trying it out 🎉

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GitHub code archives as dat source Handle Disk Image Formats (CHD, CSO, RVZ, etc.) New logo
2 participants