Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace 'eslint-config-airbnb-typescript' with Prettier #1331

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 30, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 30, 2024
@emmercm emmercm merged commit f7865f7 into main Aug 30, 2024
55 of 56 checks passed
@emmercm emmercm deleted the emmercm/prettier branch August 30, 2024 23:48
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#main" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 90.60945% with 151 lines in your changes missing coverage. Please review.

Project coverage is 92.78%. Comparing base (7c15428) to head (dbb698c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/types/files/file.ts 66.66% 21 Missing ⚠️
src/modules/datScanner.ts 75.64% 19 Missing ⚠️
src/modules/candidateWriter.ts 88.23% 14 Missing ⚠️
src/modules/directoryCleaner.ts 72.91% 13 Missing ⚠️
src/types/files/fileCache.ts 45.83% 13 Missing ⚠️
src/modules/romIndexer.ts 70.00% 9 Missing ⚠️
src/igir.ts 88.33% 7 Missing ⚠️
src/types/dats/dat.ts 76.19% 5 Missing ⚠️
src/console/progressBarCli.ts 66.66% 4 Missing ⚠️
src/modules/argumentsParser.ts 95.00% 4 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   92.60%   92.78%   +0.18%     
==========================================
  Files         118      118              
  Lines        7473     7599     +126     
  Branches     1820     1852      +32     
==========================================
+ Hits         6920     7051     +131     
- Misses        528      547      +19     
+ Partials       25        1      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant