Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: infer parent/child relationships between games #542

Merged
merged 39 commits into from
Sep 21, 2023

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Jul 30, 2023

Fixes #431

@emmercm emmercm self-assigned this Jul 30, 2023
@github-actions
Copy link

github-actions bot commented Jul 30, 2023

🧪 Branch Testing

This pull request can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/dat-parent-inferrer" [commands..] [options]

Comment generated by the Pull Request Commenter workflow.

@codecov codecov bot deleted a comment from codecov-commenter Sep 21, 2023
@emmercm emmercm marked this pull request as ready for review September 21, 2023 23:05
@emmercm emmercm enabled auto-merge (squash) September 21, 2023 23:05
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #542 (c44f5f7) into main (c952f2c) will increase coverage by 0.05%.
The diff coverage is 98.43%.

@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   93.43%   93.48%   +0.05%     
==========================================
  Files          81       82       +1     
  Lines        4797     4851      +54     
  Branches     1046     1055       +9     
==========================================
+ Hits         4482     4535      +53     
- Misses        298      299       +1     
  Partials       17       17              
Files Changed Coverage Δ
src/modules/argumentsParser.ts 99.29% <ø> (ø)
src/modules/datParentInferrer.ts 98.03% <98.03%> (ø)
src/igir.ts 96.12% <100.00%> (-0.03%) ⬇️
src/modules/datGameInferrer.ts 100.00% <100.00%> (ø)
src/types/dats/dat.ts 100.00% <100.00%> (ø)
src/types/internationalization.ts 100.00% <100.00%> (ø)

@emmercm emmercm merged commit 0765e9d into main Sep 21, 2023
51 of 52 checks passed
@emmercm emmercm deleted the emmercm/dat-parent-inferrer branch September 21, 2023 23:24
@github-actions
Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer parent/child relationships between games
1 participant