Start workers before stopping the old ones in respawn

emmett-framework · Apr 26, 2024 · dfe1762 · dfe1762
1 parent 4b3108d
commit dfe1762
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/granian/server.py b/granian/server.py
@@ -374,15 +374,17 @@ def socket_loader():
 
         for idx in workers:
             self.respawned_procs[idx] = time.time()
-            proc = self.procs.pop(idx)
-            proc.terminate()
-            proc.join()
+            logger.info(f'Respawning worker-{idx + 1}')
+            old_proc = self.procs.pop(idx)
             proc = self._spawn_proc(
                 idx=idx, target=spawn_target, callback_loader=target_loader, socket_loader=socket_loader
             )
             proc.start()
             self.procs.insert(idx, proc)
             time.sleep(delay)
+            logger.info(f'Stopping old worker-{idx + 1}')
+            old_proc.terminate()
+            old_proc.join()
 
     def _stop_workers(self):
         for proc in self.procs: