Allow specifying specific samples to get. #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batched API was a bit partially thought out in the way that if a end and then start came in the same batch then you would lose access to the previous buffer!
|
Hmm I'm wondering if for a segment we need the current silence duration and the other methods that operate on a segment 🤔 . I don't think we can recreate all of them... |
|
Another alternative might be in the batch processing if we hit a speech end not continuing with the processing and early returning and returning the number of samples written into the buffer. That might be more fully featured 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batched API was a bit partially thought out in the way that if a end and then start came in the same batch then you would lose access to the previous buffer! This is undesired as it then encourages users to implement the batching themselves for certain use cases when we could just provide something to make it more feasible with a bit of bookkeeping