Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages (next) #3289

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 9, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next, this PR will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

next is currently in pre mode so this branch has prereleases rather than normal releases. If you want to exit prereleases, run changeset pre exit on next.

⚠️⚠️⚠️⚠️⚠️⚠️

Releases

@emotion/cache@12.0.0-next.0

Major Changes

@emotion/css@12.0.0-next.0

Major Changes

Patch Changes

  • Updated dependencies [49108c8]:
    • @emotion/cache@12.0.0-next.0

@emotion/jest@12.0.0-next.0

Major Changes

@emotion/primitives-core@12.0.0-next.0

Major Changes

Patch Changes

@emotion/react@12.0.0-next.0

Major Changes

Patch Changes

  • Updated dependencies [49108c8]:
    • @emotion/cache@12.0.0-next.0

@emotion/styled@12.0.0-next.0

Major Changes

Patch Changes

@emotion/native@12.0.0-next.0

Patch Changes

  • Updated dependencies [61fcc80]:
    • @emotion/primitives-core@12.0.0-next.0

@emotion/primitives@12.0.0-next.0

Patch Changes

  • Updated dependencies [61fcc80]:
    • @emotion/primitives-core@12.0.0-next.0

@emotion/server@12.0.0-next.0

Patch Changes

  • Updated dependencies [49108c8]:
    • @emotion/css@12.0.0-next.0

Copy link

codesandbox-ci bot commented Dec 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions github-actions bot force-pushed the changeset-release/next branch 6 times, most recently from 74999ff to 1b86fce Compare December 15, 2024 23:29
@github-actions github-actions bot force-pushed the changeset-release/next branch from 1b86fce to 3c94a1a Compare January 13, 2025 07:18
@zrosenbauer
Copy link

zrosenbauer commented Feb 1, 2025

@Andarist any idea when you will cut a canary etc. for v12?

I'm hard blocked due to using React 19 & Tanstack Start (I'd open a PR but it already looks fixed/completed in this changeset).

Happy to test, help work through issues!

@Andarist
Copy link
Member

Andarist commented Feb 1, 2025

What are you blocked on? Emotion 11 should still work with React 19, it just doesn't benefit from some new APIs that we could use with React 19

@zrosenbauer
Copy link

Sorry blocked meaning I need the work you've done on 'renderToPipeableStream' as we are working on public marketing site and we need to be able to render the style sheets on the server (aka can't inject in browser)

In Tanstack Start it's built using the newer methods.

Tanstack treats all of DOM as react similar to Next.

I'm volunteering to be the canary in the coal mine and test it out in prod!

@zrosenbauer
Copy link

Here is the code from Tanstack

https://github.com/TanStack/router/blob/main/packages/start-server/src/defaultStreamHandler.tsx#L24C14-L24C28

My assumption is the work you've already done will give us native support like it worked on older versions.

@Andarist
Copy link
Member

Andarist commented Feb 1, 2025

Then this PR doesn't (yet) contain the changes you need. You need this PR: #3295 . The problem with it is that style rendering in browsers (on the client side) becomes way slower with it (but honestly, I don't know how much of an impact that has on real sites - one benchmark that we have shows 10x+ time increase). The root cause behind it is that React has not used CSSOM APIs for style insertions on the client side. I'm in contact with a React team member about this and we plan to discuss this in more detail in 2 weeks to see if we could collaborate on improving this in React itself.

@zrosenbauer
Copy link

@Andarist ahhh got yea, I jumped the gun when I saw the PR with React 19 being required.

Awesome stuff, I'll keep an eye one it. Appreciate all the hard work on this!

@Andarist
Copy link
Member

Andarist commented Feb 1, 2025

If your site is mostly static then that perf degradation wouldn't really affect you but it's hard to justify merging that PR and releasing a prerelease version when we know things can get so much slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants