Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Account for !important tag when checking for content text being quoted properly #3313

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amubushar
Copy link

@amubushar amubushar commented Feb 17, 2025

What:

Currently, CSS that uses content with quoted text followed by an !important tag breaks in development mode:
e.g css={{ content: "'•' !important" }} as mentioned in #3183.

Why:

This is because we currently check for quoted content by matching the starting character and ending character of the content, however with an !important tag added it will no longer match correctly.

How:

We now identify the first quote character, find its last occurrence and then check if the remainder after last occurrence is !important, if it is we no longer error incorrectly.

Copy link

changeset-bot bot commented Feb 17, 2025

⚠️ No Changeset found

Latest commit: e417f1a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant