fixing CI

empress · Mar 7, 2024 · bd0d68b · bd0d68b
1 parent e81a31f
commit bd0d68b
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -69,8 +69,6 @@ jobs:
           - ember-lts-5.4
           - ember-release
           - embroider-safe
-          - embroider-optimized
-          - no-deprecations
 
     steps:
       - uses: actions/checkout@v4
@@ -101,6 +99,12 @@ jobs:
           - ember-beta
           - ember-release-no-deprecations
 
+          # this needs a fix in ember-cli-fastboot before it will ever pass
+          - embroider-optimized
+
+          # our current deprecations are coming from guidemaker so they need to be fixed there
+          - no-deprecations
+
 
     steps:
       - uses: actions/checkout@v4
@@ -116,3 +120,8 @@ jobs:
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }} --skip-cleanup
         working-directory: test-app
+      - uses: mainmatter/continue-on-error-comment@v1
+        with:
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+          outcome: ${{ steps.tests.outcome }}
+          test-id: ${{ matrix.try-scenario }}
diff --git a/test-app/config/ember-try.js b/test-app/config/ember-try.js
@@ -72,6 +72,23 @@ module.exports = async function () {
           },
         },
       },
+      {
+        name: 'no-deprecations',
+        npm: {
+          devDependencies: {
+            'ember-deprecation-error': '*',
+          },
+        },
+      },
+      {
+        name: 'ember-release-no-deprecations',
+        npm: {
+          devDependencies: {
+            'ember-source': await getChannelURL('release'),
+            'ember-deprecation-error': '*',
+          },
+        },
+      },
       embroiderSafe(),
       embroiderOptimized(),
     ],