Add Starscream 5.x support (keeping 4.x compatibility) for CocoaMQTT WebSocket #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starscream 5.x changed the
WebSocketDelegateAPI to useWebSocketClientinstead ofWebSocket. This PR updates CocoaMQTT's WebSocket integration to compile with Starscream 5.x while preserving compatibility with 4.x, and relaxes dependency constraints so downstream projects can resolve either version.Motivation
Type 'CocoaMQTTWebSocket.StarscreamConnection' does not conform to protocol 'WebSocketDelegate'Candidate has non-matching type '(WebSocketEvent, WebSocket) -> ()'Changes
Source/CocoaMQTTWebSocket.swiftWebSocketDelegateimplementation to the 5.x signature:didReceive(event: WebSocketEvent, client: WebSocketClient)didReceive(event: WebSocketEvent, client: WebSocket)Package.swift"4.0.8" ..< "6.0.0"CocoaMQTT.podspec">= 4.0.4", "< 6.0"Backward compatibility
Testing