fix: tolerate corrupted COMMIT file #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
force-pushed
the
tolerate-corrupted-commit-file
branch
from
a864316 to
6b9d176
Compare
savonarola
approved these changes
Nov 7, 2024
qzhuyan
reviewed
Nov 7, 2024
| %% ignore empty file | ||
| %% sometimes (e.g. IOPS limited) do_commit (write to .tmp then rename) may fail | ||
| %% to write but succeed in rename. | ||
| %% ignoring COMMIT file leads to message receliver, so warning level |
There was a problem hiding this comment.
do you think it worth to check if COMMIT.tmp exists and use it?
There was a problem hiding this comment.
don't think it worth the effort.
qzhuyan
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed COMMIT file corruption in a system which got IOPS limited.
The file is updated as follows
COMMIT.tmpCOMMIT.tmptoCOMMIT.Due to unknown reason,
COMMITfile can end up with empty content.This PR ignores empty
COMMITfile, also made the code to tolerate corrupted content.