Open
Conversation
sbc100
reviewed
Feb 27, 2026
Member
|
This makes sense to me. |
sbc100
reviewed
Mar 4, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Could you add a test for this casting? Maybe modify one of the existing tests?
system/include/compat/avx2intrin.h
Outdated
| __m256i __a = (__A); \ | ||
| __m256i __b = (__B); \ | ||
| __m256i_internal __a = __m256i_to_internal(__A); \ | ||
| __m256i_internal __b = __m256i_to_internal(__B); \ |
Collaborator
There was a problem hiding this comment.
Can you fix the alignment of the trailing \ here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes
__m256*defined as vector types (i.e.__attribute__((__vector_size(32)))) so they can be cast to each other. The implementation of all the AVX functions are unchanged, but require conversion internally to the old struct types in order to call m128 functions on each lane.Fixes #24076, fixes #26352.