Skip to content

Fix pending signals to be TLS#26666

Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100:sig_pending
Open

Fix pending signals to be TLS#26666
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100:sig_pending

Conversation

@sbc100
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 commented Apr 10, 2026

Also, add some testing for this. I also ran this test under native clang / glibc on my desktop and got the expected results.

@sbc100 sbc100 requested a review from kripken April 10, 2026 18:56
@sbc100 sbc100 force-pushed the sig_pending branch 3 times, most recently from 0df0b51 to 6643dc8 Compare April 10, 2026 19:06
@sbc100 sbc100 requested a review from dschuff April 10, 2026 19:17
Also, add some testing for this.  I also ran this test under native
clang / glibc on my desktop and got the expected results.
@sbc100 sbc100 enabled auto-merge (squash) April 10, 2026 21:22
@dschuff
Copy link
Copy Markdown
Member

dschuff commented Apr 10, 2026

Is this in reference to a particular bug?

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 10, 2026

Is this in reference to a particular bug?

No, I just noticed this will browsing the source.

@sbc100
Copy link
Copy Markdown
Collaborator Author

sbc100 commented Apr 10, 2026

I was looking into improving the async signal delivery and I noticed that we were not even storing pending signals per thread!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants