-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
113/hotfix homepage #124
Merged
Merged
113/hotfix homepage #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in popup.tsx useEffect relates #113
camelPhonso
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #113
This PR set out to fix the issue where the homepage would sometime load the incorrect content when the user had chosen a project not the current one. In the process it has attempt to unify user data fetching the context updates attempting to make the db the SST for the app and moving away from some of the feature we originally used storage for.
Files changed
index.ts
- adds await to storage on install callselectNewActiveProject.ts
- returns changed values to front end and removes from storageupdateUserDetails.ts / LoginPage.tsx / SignupPage.tsx / UserTypes.ts
- removes values from userSessionsHomePage.tsx
-updates function and label nameSelectProjectButton.tsx / ProfilePage.tsx
- updates context store with returned valuessrc/popup.tsx
- adds loading states and sets store based on userSession statusstore.ts
- add login user methodsrc/utils/eventAlarmListener.ts
- replaces store values with database call and return changed values to from end.