Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#107/pagination nav redesign #127

Merged
merged 4 commits into from
Nov 12, 2024
Merged

#107/pagination nav redesign #127

merged 4 commits into from
Nov 12, 2024

Conversation

camelPhonso
Copy link
Contributor

Description

Closes #122
Closes #107

Re-styles the PaginationNav component and introduces a fix to the pagination bug reported for FavouritesPage

Files changed

  • components/PaginationNav/** - updated the styling of this component to match the new figma design
  • FavouritesPage.tsx - updated the useEffect dependency array and refactored the logic on handlePopupRemove to enforce a re-render of the list when deleting a popup reduces the total list to a multiple of 6 or to 0

UI changes

Screenshot 2024-11-11 at 15 56 43

Changes to Documentation

n/a

Tests

n/a

Copy link
Contributor

@nichgalzin nichgalzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna approve this with the note that the evaluation in the useEffect dependency array may need to be refactored in the future. It seems the practice would be to separate this into two effects, but this is working and seems not to effect performance so think it's fine to leave.

@nichgalzin nichgalzin merged commit 4fb9636 into dev Nov 12, 2024
1 check passed
@nichgalzin nichgalzin deleted the #107/pagination-nav-redesign branch November 12, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants