-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
119/button styling #132
Merged
Merged
119/button styling #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelPhonso
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking sharp but we've got some unintended changes going on need a bit of a fix for the z-index in the new buttons
…tate being animtated Relates 119
camelPhonso
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smashing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #119
This pull request includes several updates to the
BackButton
,PopupCard
, and global button styles, along with a minor change to theFavouritesPage
component. The most important changes are summarised below:Updates to
BackButton
component:BackButton.css
to improve visibility.text-xl
class from the back button inBackButton.tsx
to simplify the styling.Updates to
PopupCard
component:close-button--container
class and adjusted thepopup-card--remove-button
class inPopupCard.css
to enhance the styling and positioning of the remove button.PopupCard.tsx
to include a new close button container and refactored the remove button handling for better user interaction.Global button styles:
globals.css
to reset border, background, and text alignment properties, and added focus styles for better accessibility.Minor changes:
FavouritesPage.tsx
to move thekey
prop to the correct element for better React key management.PopupInfo.css
to align with global button styles and ensure consistency.UI changes