Skip to content

Commit

Permalink
WRR-15935: Upgrade to React19 (#3307)
Browse files Browse the repository at this point in the history
* WRQ-222: Upgrade to React 19 (#3240)

* update react19 rc

* update npm-shrinkwrap with --force option

* add --force option on npm run bootstrap

* fix typo

* use cli feature/WRQ-21653 branch

* use npm install --force option on travis

* comment findDOMNode()

* fix lint errors

* revert findDOMNode() deletion and use cli feature/enact_v5 branch

* revert findDOMNode() deletion 2

* Update .travis.yml

* Update .travis.yml

* update react rc 20240529 version

* Removed the caret for react and update sampler's shrinkwrap

* WRR-14717: Update React version to 19 in enact packages

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

* Skipped the unit tests that uses the React APIs, which was removed from react19

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

* Added missing caret

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

* Added a log with React version upgrade in CHANGELOG

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

* Restored travis.yml file

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

* Restored package.json file

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

---------

Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
  • Loading branch information
4 people authored Jan 15, 2025
1 parent 99e739c commit 5ca20e8
Show file tree
Hide file tree
Showing 11 changed files with 488 additions and 660 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

The following is a curated list of changes in the Enact project, newest changes on the top.

## [unreleased]

- Update dependencies including React 19.0.0

## [5.0.0-alpha.3] - 2024-12-02

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {Component, createRef} from 'react';
import EnactPropTypes from '../prop-types';


describe('prop-types', () => {
describe.skip('prop-types', () => {
const DummyElement = (<div />);
const DummyRenderable = () => DummyElement;
const dummyString = 'Some String';
Expand Down
4 changes: 2 additions & 2 deletions packages/core/kind/tests/kind-specs.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ describe('kind', () => {
expect(minimalDiv).toBeInTheDocument();
});

test('should default {label} property', () => {
test.skip('should default {label} property', () => {
const subject = <Kind prop={1} />;

const expected = 'Label';
Expand All @@ -73,7 +73,7 @@ describe('kind', () => {
expect(actual).toBe(expected);
});

test('should default {label} property when explicitly undefined', () => {
test.skip('should default {label} property when explicitly undefined', () => {
// Explicitly testing for undefined
// eslint-disable-next-line no-undefined
const subject = <Kind label={undefined} prop={1} />;
Expand Down
6 changes: 3 additions & 3 deletions packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
"invariant": "^2.2.4",
"prop-types": "^15.8.1",
"ramda": "^0.30.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-is": "^18.3.1",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"react-is": "^19.0.0",
"warning": "^4.0.3"
}
}
4 changes: 2 additions & 2 deletions packages/i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@
"@enact/core": "^5.0.0-alpha.3",
"prop-types": "^15.8.1",
"ramda": "^0.30.1",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react": "^19.0.0",
"react-dom": "^19.0.0",
"xhr": "^2.6.0"
},
"peerDependencies": {
Expand Down
Loading

0 comments on commit 5ca20e8

Please sign in to comment.