-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Remove Python 3.9 from workflow matrix #9781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
We should probably also update all the package metadata and docs? |
yes, thats why it is draft for now. |
3f37297
to
3003fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also remove unused targets from the tox.ini
file
I'm not familiar in what way these extra targets are special so that they should only run with the oldest support version. Why is that? |
Hum... I'm actually not sure it matters. I said that because that seemed like how they were setup and it's probably where we're most likely to break something, but it's just a gut feeling. A theorical example that comes to mind would be removal of an optional dependency because it's now part of the std lib (pytz/zoneinfo). We could have some tests break on older Python versions where ZoneInfo wouldn't be supported if we forgot about it... The base job might have caught such issue: running on the older Python without the optional dep. Lines 28 to 32 in 0f57622
Seems like the dist job treats some warnings as errors: Lines 34 to 39 in 0f57622
So maybe this one should actually run on the most recent Python? |
According to https://endoflife.date/python, EOL is at the end of the month. However, I'm happy to merge this already so it goes in the next release. Looks good to go from my perspective, unless there are any objections from other maintainers? |
EOL in october....