Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop private imports on test_utils.py #2851

Closed
wants to merge 9 commits into from
Closed

Conversation

T-256
Copy link
Contributor

@T-256 T-256 commented Sep 17, 2023

Summary

closes #2492

get_ca_bundle_from_env moved to where it's calling.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@T-256 T-256 marked this pull request as draft September 17, 2023 00:38
@T-256 T-256 marked this pull request as ready for review September 17, 2023 15:20
@karpetrosyan
Copy link
Member

Please optimize the number of git commits.
You can even do fewer commits or force push them at the end so that we only see a few commits rather than the commit army.
I believe it will make the pull request more attractive and easier to review.

@T-256 T-256 force-pushed the test_utils branch 2 times, most recently from df6a665 to 93433d0 Compare October 30, 2023 15:17
@tomchristie
Copy link
Member

Okay, so the intention here is to change test_utils.py so that we're only ever testing against public API.

There's a mix here of some tests that do that, and some other tests that correctly switch to only using public imports, but switch to using private accessors.

I could review the PR as a whole, but it's a bit of a mix.

Perhaps an easier approach to getting this resolved would be to only target one type of change at a time.

@T-256
Copy link
Contributor Author

T-256 commented Oct 30, 2023

but switch to using private accessors.

previous PR like this also used private accessor, so I thought it's no problem using them in tests at all.

@T-256
Copy link
Contributor Author

T-256 commented Jan 16, 2024

close in favor of separating to chunks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test cases that import from private namespace.
3 participants