-
-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop private imports on test_utils.py
#2851
Conversation
Please optimize the number of git commits. |
df6a665
to
93433d0
Compare
Okay, so the intention here is to change There's a mix here of some tests that do that, and some other tests that correctly switch to only using public imports, but switch to using private accessors. I could review the PR as a whole, but it's a bit of a mix. Perhaps an easier approach to getting this resolved would be to only target one type of change at a time. |
previous PR like this also used private accessor, so I thought it's no problem using them in tests at all. |
close in favor of separating to chunks... |
Summary
closes #2492
get_ca_bundle_from_env
moved to where it's calling.Checklist