Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make async dependencies optional. #2858
base: master
Are you sure you want to change the base?
Make async dependencies optional. #2858
Changes from 3 commits
0dd72fc
f4dd500
40aa60c
56b2fb0
e4e8fb2
3741513
9b36a20
aa9ca07
0e34e2c
88d9324
3ebb3a5
4e58ae6
6a4ea7a
85886d7
7c10773
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting... currently we're including the
httpcore
dependencies explicitly.Eg.
pip install httpx[socks]
uses the dependencysocksio==1.*
instead of the dependencyhttpcore[socks]
.The second style makes more sense, because that's what we're actually trying to effect... but I'm a bit hesitant that some Python install tooling might incorrectly fail to install
httpcore[socks]
as an optional dependency when thehttpcore
dependancy is already included. Is my hesitancy well founded here, or are we okay to use this new style throughout?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should always work but you're right that it's tool dependent and the Python specification around this does not provide guarantees.