Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encode host #2886

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix encode host #2886

merged 2 commits into from
Oct 10, 2023

Conversation

robinaly
Copy link
Contributor

Summary

The encode_host method used the regular expression in the variable IPv4_STYLE_HOSTNAME. This was before:
r"^[0-9]+.[0-9]+.[0-9]+.[0-9]+$" which wrongly allows hostnames like 023b76x43144 to pas as a ipv4 address. This is now fixed by changed the url to r"^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$"

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.: Not applicable IMHO

@tomchristie tomchristie merged commit e63b659 into encode:master Oct 10, 2023
5 checks passed
Tunglies added a commit to Tunglies/httpx that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants