Switch networking to @polkadot/rpc-provider and support for author_submitAndWatchExtrinsic for trusted calls
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1815e0c.
…ork, but we don't get an update
clangenb
force-pushed
the
cl/rpc-provider-socket
branch
from
286f292
to
df0ba52
Compare
clangenb
changed the title
@polkadot/rpc-provider and add support for author_submitAndWatchExtrinsic trusted calls@polkadot/rpc-provider and support for author_submitAndWatchExtrinsic for trusted calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this removes the low level, homegrown websocket implementation that we used to have until now. We now use the
@polkadot/rpc-providersWsProviderfor our networking, which has built in support for JSON RPC 2.0 subscriptions, however this meant that we needed to introduce a minor change, as our worker does not fully satisfy the protocol, see integritee-network/worker#1623. Closes #88I had to copy the
rpc-providerto this code base as we needed to be able to control the websocket, such that we can run integration tests against local worker setups, which means we need to accept the worker's self-signed certificate.Lastly, I removed the
EncointerWorkerfor now, as it was too heavily outdated, but we can quite easily re-introduce it, with the new paradigm once the time has come.This branch has now been released on npm as 0.16.0-alpha.0.