feat: enable []string as a valid set-cookie type, fixes #1548 #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All committers have signed the CLA. |
TheGB0077
force-pushed
the
feat-cookie-array
branch
from
178dfcf to
6930142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: Setting multiple Cookies as part of one request is often needed, but current limitations on encore go don't allow this without using raw api endpoints. This PR adds []string as a valid type for the struct tag "Set-Cookie" in order to provide a clean api for setting up multiple Cookies from a list.
Out of scope on this PR: Adding *http.Cookie type to allow list
fixes #1548