Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic when parsing DWARF 2 line info for empty section #125

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

AetiasHax
Copy link
Contributor

mwccarm emits individual .text sections for each function, and in some cases it can emit an empty .text section which will be ignored by objdiff. This causes the DWARF 2 line info parser to unwrap a None value when attempting to iterate to the empty section.

Now it's fixed by letting the None section value cascade up into the lines variable instead of unwrapping it.

@AetiasHax AetiasHax changed the title Dwarf empty section Fix panic when parsing DWARF 2 line info for empty section Oct 19, 2024
@encounter
Copy link
Owner

Thanks!

@encounter encounter merged commit 6ff8d00 into encounter:main Oct 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants