타이어 결과물 조회 API 구현 close #58 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinlee1703
reviewed
Feb 23, 2024
| public class ResultResponseDTO { | ||
| private String id; | ||
|
|
||
| private Long patternId; |
There was a problem hiding this comment.
P3: 이렇게 안주셔도 되고 Pattern 객체 통째로 주셔도 됩니다~
There was a problem hiding this comment.
Pattern 객체 통째로 주면 id, name, price 등등을 프론트에서 알아서 받는 건가요?
There was a problem hiding this comment.
response.pattern.id 이런 식으로 활용할 것 같아요~
jinlee1703
reviewed
Feb 23, 2024
| @Service | ||
| @RequiredArgsConstructor | ||
| public class ResultService { | ||
| private final ResultRepository resultRepository; | ||
|
|
||
| public ResultResponseDTO findById(String id) { |
There was a problem hiding this comment.
P4: create, read, update, delete와 같이 메서드명을 통일하면 좋을 것 같아요~
jinlee1703
reviewed
Feb 23, 2024
| import org.springframework.web.bind.annotation.*; | ||
|
|
||
| import java.util.List; | ||
| import java.util.UUID; |
|
날이 갈수록 코드 구현이 느는 것 같아! |
|
날이 갈수록 이해력이 좋아지는 것 같습니다~ 테스트 코드 작성까지만 화이팅해주세요! |
jinlee1703
reviewed
Feb 28, 2024
|
|
||
| @OneToMany(mappedBy = "color") //읽기만 가능 | ||
| private List<Result> results = new ArrayList<>(); | ||
| // @OneToMany(mappedBy = "color") //읽기만 가능 |
| @ResponseBody | ||
| @ApiResponses({ | ||
| @ApiResponse(responseCode = "200", description = "결과물 조회 성공"), | ||
| @ApiResponse(responseCode = "400", description = "잘못된 요청, UUID 형식이 아닌 id가 입력된 경우"), |
There was a problem hiding this comment.
P3: 실제로 구현되지 않은 Response들은 작성할 필요가 없습니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Problem Solving
To Reviewer