box_tree: Add subtree filtering support to QueryFilter #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add subtree_root field to QueryFilter to enable restricting spatial queries to specific subtrees. This allows applications to scope hit testing and rectangle queries to particular branches of the tree. - Add QueryFilter::in_subtree() builder method - Add Tree::is_descendant_of() helper for subtree membership checks - Update QueryFilter::matches() to respect subtree boundaries - Update hit_test_point and intersect_rect to use new filtering - Add tests demonstrating subtree isolation - Update documentation and regenerate README The O(depth) descendant check scales well for typical use cases where subtree queries target shallow branches. This approach preserves the single spatial index while enabling clean subtree scoping.
tomcur
reviewed
Dec 7, 2025
Comment on lines
+151
to
+152
| if let Some(subtree_root) = self.subtree_root | ||
| && !tree.is_descendant_of(node_id, subtree_root) |
Contributor
There was a problem hiding this comment.
As you mentioned this isn't completely ideal (O(n) by itself, but for every node in the subtree!). I'm not too concerned for now, as that's only paid if it's actually used.
We can probably make this O(1) through something like building a tight post ordering and keeping track of subtree size, I've needed to do something similar in https://github.com/endoli/fiksi/blob/4fd727e696a98d9368c66e51b23db238d023dad9/solvi/src/decomposition/sparse/cholesky.rs#L164-L174 but that doesn't do anything for incremental updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add subtree_root field to QueryFilter to enable restricting spatial queries to specific subtrees. This allows applications to scope hit testing and rectangle queries to particular branches of the tree.
The descendant check is O(depth), there could be ways to improve this but I haven't done it here