Add transform_encoder crate #74
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This isn't yet tested and I'll need to add those but feedback on the API would be good |
Contributor
waywardmonkeys
left a comment
waywardmonkeys
left a comment
There was a problem hiding this comment.
Getting started on looking at this ... I think @xorgy should take a look as well.
| /// bounds if configured. | ||
| pub fn set_pan_by_view(&mut self, pan: Vec2) { | ||
| self.pan = pan; | ||
| self.clamp_to_bounds(); |
Contributor
There was a problem hiding this comment.
I think this needs to self.rebuild_transforms();
Contributor
Author
There was a problem hiding this comment.
so should the pan_by_view method also call self.rebuild_transforms()?
|
|
||
| /// Translation operations | ||
| /// | ||
| /// Note: Factor inputs should NOT be used with Pan operations since multiplicative |
Contributor
There was a problem hiding this comment.
The use of "Factor" here requires that someone has read the docs for TransformAction, I think.
Also, with "Pan" ... either leave it caps for an identifier and link it, or use lowercase.
jrmoulton
force-pushed
the
transform-encoder
branch
2 times, most recently
from
3d6b908 to
e9f8e20
Compare
jrmoulton
force-pushed
the
transform-encoder
branch
from
e9f8e20 to
99b3c0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new transform encoder crate for mapping of ui events to transform actions.
The focus of this is to have a fully typed safe API for creating the mappings.