Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Authentication - Part 1 #39

Merged
merged 59 commits into from
Nov 25, 2023
Merged

feat: Authentication - Part 1 #39

merged 59 commits into from
Nov 25, 2023

Conversation

enesky
Copy link
Owner

@enesky enesky commented Nov 19, 2023 •
edited
Loading

🔴 [Mandatory] What's the change?

  • Sign in, Register actions added with Firebase Authentication
  • Email, Google and Anonymous types added
  • Login design is finalized
  • TODO's for Part 2:
  • Credential manager added to safe and quick login
  • Fix email auth problems
  • Update action usages with Channels

🔴 [Mandatory] Why do we need this change?

  • To authenticate users for the app

Related issues/PRs/Jira ticket links

🔴 [Mandatory if it's UI related] Screenshots

  • Screenshot 2023-11-26 at 01 35 42

@enesky enesky linked an issue Nov 19, 2023 that may be closed by this pull request
[Feature] - Credential Manager #40
Closed
enesky added 17 commits November 19, 2023 23:42
@enesky
added: Google Play services auth library
92077e1
@enesky
added: lifecycle-runtime-compose lib for collectAsStateWithLifecycle(…
e721add 
…) usage
@enesky
added: google icon
cda7ee8
@enesky
removed: navigation folder and its contents moved out
c085cc9
@enesky
added: UiStateDelegate.kt class for delegation of ui state usages
b5d864f
@enesky
added: UiStateDelegate usage to LoginViewModel and LoginScreen
344e2c8
@enesky
added: LoginUiState class for Login screen's state management
3b3b029
@enesky
added: core/data module added to FeaturePlugin and directly to core/c…
ea08d96 
…ommon module
@enesky
updated: gitignore -> added: google-services.json
9490c6d
@enesky
updated: gitignore -> added: google-services.json
1feced6
@enesky
removed: google-services.json
6604372
@enesky
updated: AuthenticationPlugin usage on modules
d1c8505
@enesky
added: Google auth key to local.properties and its used with buildcon…
8e7d8ca 
…fig so buildconfig settings added to AuthenticationPlugin
@enesky
added: AuthManager to handle all auth operations
ceb0d8f
@enesky
added: AuthManager provider to appModule
7e24147
@enesky
added: Custom Logger utils to handle logs only on debug mode
77ef6cd
@enesky
fixed: Spotless + Detekt issues
e3ab41b
enesky added 27 commits November 22, 2023 09:41
@enesky
added: Google api key to local.properties section
b4388cf
@enesky
added: google-services.json to project because cant create builds on …
7dd0f2e 
…ci-cd without it
@enesky
updated: LoginUiState with signInResult data
b813dff
@enesky
added: signInWithGoogle funcs to LoginViewModel
8ac23b0
@enesky
removed: app_name value removed because it can affect actual app naming
9838d8b
@enesky
updated: modules for authmanager
8c42ef3
@enesky
updated: AuthManager with Executor usage instead of Activity
c7acbd9
@enesky
updated: UiStateDelegate with new initialState setup
0d6a4c0
@enesky
updated: LoginScreen with GoogleSignIn
cfcaa64
@enesky
fixed: spotless-detekt issues
2fa2a1f
@enesky
added: new exception check on signInGoogle
574da9d
@enesky
added: result fail check on LoginScreen
5b8030d
@enesky
updated: google-services.json
41ec01f
@enesky
updated: Starting destination with authenticated user check
862fb53
@enesky
updated: AuthManager with clearing basic suspend funcs and returning …
6b3c743 
…SignInResult at signInAnonymously()
@enesky
added: ui module to FeaturePlugin and designSystem module to ui module
7a91199
@enesky
added: 2 different loading animations
6d0e65f
@enesky
added: SignInAnonymously func to LoginViewModel
9852178
@enesky
completed: SignInAnonymously action
3132b59
@enesky
added: TODO about global loading screen
99600ba
@enesky
added: Loading to home screen
9f5c286
@enesky
updated: LoginScreen ui with new SignInButtonWithLogo component
a151383
@enesky
updated: sign in with email functions on AuthManager
0880355
@enesky
updated: LoginScreen design and function usages
dc850a5
@enesky
added: email sign in functions to LoginViewModel
05aa9b4
@enesky
fixed: detekt issues
46d464d
@enesky
fixed: spotless issues
f4bd719
@enesky enesky merged commit 8a1f1f6 into main Nov 25, 2023
1 check passed
@enesky enesky changed the title feat: Authentication feat: Authentication - Part 1 Nov 26, 2023
@enesky enesky linked an issue Nov 28, 2023 that may be closed by this pull request
[Bug] - Email auth has token problem #46
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] - Email auth has token problem [Feature] - Credential Manager
1 participant
@enesky