Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use node20 in local GH actions #256

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

RoadRunnr
Copy link
Contributor

This fixes the GH action failures and kind of fixes #255.

The root cause for #255 is actually the release process. Generating the ./dist folder has to be done with node-20 and ./node_modules should not be included in the release.

For a working release check RoadRunnr/setup-kind@1e2bc39. That repo state was create with nodejs v20.16.0 on Ubuntu 22.10. I've successfully tested it in a private repository that failed with the json5 problem before.

working for me with uses: RoadRunnr/setup-kind@1e2bc396f646c7e493975e3802f80588c825e5d0

@radu-matei
Copy link
Member

radu-matei commented Oct 31, 2024

Oh, good catch!
Thank you!

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.13%. Comparing base (eb0371b) to head (5724bac).
Report is 12 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   62.81%   63.13%   +0.31%     
==========================================
  Files           6        6              
  Lines         199      198       -1     
  Branches       34       34              
==========================================
  Hits          125      125              
+ Misses         70       69       -1     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@radu-matei radu-matei merged commit 71e45b9 into engineerd:master Oct 31, 2024
2 checks passed
@radu-matei
Copy link
Member

Will cut a new release later tonight, thanks a again for catching this and for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install v0.6.0 failed
4 participants