Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLA-2038] FuelTanks support for v2.0.0 #66

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

leonardocustodio
Copy link
Member

@leonardocustodio leonardocustodio commented Oct 14, 2024

PR Type

enhancement, configuration changes


Description

  • Updated PHP version to 8.3 across multiple GitHub workflows.
  • Modified composer commands to include enjin/platform-core dependency.
  • Adjusted dependencies in composer.json for both production and development environments.
  • Removed and added steps in GitHub workflows for consistency and updated practices.

Changes walkthrough 📝

Relevant files
Formatting
CODEOWNERS
Minor formatting adjustment in CODEOWNERS file.                   

.github/CODEOWNERS

  • Removed an empty line for formatting consistency.
+0/-1     
Configuration changes
run_tests.yml
Update PHP version and dependencies in test workflow.       

.github/workflows/run_tests.yml

  • Updated PHP version from 8.2 to 8.3.
  • Modified composer install command options.
  • Added a new dependency enjin/platform-core.
  • Removed Laravel Pint step.
  • +3/-6     
    sast.yml
    Update PHP version and dependencies in SAST workflow.       

    .github/workflows/sast.yml

  • Updated PHP version from 8.2 to 8.3.
  • Added a new dependency enjin/platform-core.
  • Added Laravel Pint step.
  • +6/-1     
    security_checker.yml
    Update PHP version and dependencies in security checker workflow.

    .github/workflows/security_checker.yml

  • Updated PHP version from 8.1 to 8.3.
  • Added a new dependency enjin/platform-core.
  • +3/-2     
    Enhancement
    composer.json
    Update PHP requirements and dependencies in composer.json.

    composer.json

  • Updated PHP requirement to ^8.3.
  • Added new dependencies for development and production.
  • Adjusted prefer-stable setting to true.
  • +19/-19 

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Dependency Management
    The addition of 'enjin/platform-core:dev-master' directly in the workflow scripts could lead to instability. Consider specifying a stable version or handling this dependency through 'composer.json'.

    Dependency Management
    The addition of 'enjin/platform-core:dev-master' in the security checker workflow may not be appropriate. This dependency should be managed in 'composer.json' to ensure version control and stability.

    PHP Version Constraint
    The PHP version constraint is updated to '^8.3' which might drop support for any previous versions that are still in use. Ensure this change is intentional and tested.

    Copy link

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Ensure stable and predictable dependencies by specifying version constraints

    Ensure that the composer require command specifies a version constraint for
    enjin/platform-core to avoid potential issues with unstable versions.

    .github/workflows/run_tests.yml [62]

    -composer require enjin/platform-core:dev-master
    +composer require enjin/platform-core:^1.0
    Suggestion importance[1-10]: 8

    Why: Specifying a version constraint for enjin/platform-core ensures stability and predictability in dependency management, which is crucial for maintaining a reliable build environment.

    8
    Prevent potential future compatibility issues by specifying version constraints

    Specify version constraints for enjin/platform-core in composer require to avoid
    potential compatibility issues with future updates.

    .github/workflows/sast.yml [54]

    -composer require enjin/platform-core:dev-master
    +composer require enjin/platform-core:^1.0
    Suggestion importance[1-10]: 8

    Why: Specifying version constraints for enjin/platform-core helps avoid compatibility issues with future updates, ensuring a stable and predictable dependency environment.

    8
    Performance
    Improve the efficiency of composer installations in CI workflows

    Consider using the --prefer-dist and --optimize-autoloader options with composer
    install to improve installation speed and efficiency in production environments.

    .github/workflows/run_tests.yml [61]

    -composer install --no-interaction --no-progress
    +composer install --no-interaction --no-progress --prefer-dist --optimize-autoloader
    Suggestion importance[1-10]: 7

    Why: Adding the --prefer-dist and --optimize-autoloader options can improve the efficiency of composer installations, especially in CI environments. This suggestion is relevant and beneficial for performance.

    7
    Enhance the speed and reliability of dependency installations in security workflows

    Add the --prefer-dist option to composer install for faster dependency installation
    by downloading stable versions where possible.

    .github/workflows/security_checker.yml [36]

    -composer install --no-interaction --no-progress
    +composer install --no-interaction --no-progress --prefer-dist
    Suggestion importance[1-10]: 6

    Why: The --prefer-dist option can speed up dependency installations by downloading stable versions, which is beneficial for CI workflows. This suggestion improves performance and reliability.

    6

    @leonardocustodio leonardocustodio changed the title [WIP] [PLA-2038] FuelTanks support for v2.0.0 [PLA-2038] FuelTanks support for v2.0.0 Oct 15, 2024
    @leonardocustodio leonardocustodio requested review from v16Studios and enjinabner and removed request for v16Studios October 15, 2024 00:36
    @enjinabner
    Copy link
    Contributor

    Tests are failing?

    @leonardocustodio
    Copy link
    Member Author

    Test are passing, SAST is failing, same issue as core

    @leonardocustodio leonardocustodio merged commit 660b9f6 into master Oct 15, 2024
    5 of 7 checks passed
    @leonardocustodio leonardocustodio deleted the PLA-2038 branch October 15, 2024 00:42
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Development

    Successfully merging this pull request may close these issues.

    2 participants