[PLA-1756] add claim conditions view

[zlayine]

PR Type

enhancement, bug_fix

---

Description

• Added UI components and API support for displaying and updating claim conditions in beam details.
• Enhanced GraphQL queries and mutations to handle claim conditions, allowing for better data management and display.
• Updated Vue components to integrate claim conditions into the existing beam management system.

---

Changes walkthrough 📝

Relevant files

Enhancement

DetailsBeamSlideover.vue Add Claim Conditions Display in DetailsBeamSlideover          resources/js/components/slideovers/beam/DetailsBeamSlideover.vue Added a new section to display claim conditions in the DetailsBeamSlideover component. Implemented a method formatCondition to format the display of claim conditions. +17/-0    UpdateBeamSlideover.vue Support Claim Conditions in UpdateBeamSlideover                    resources/js/components/slideovers/beam/UpdateBeamSlideover.vue Included claim conditions in the props for the UpdateBeamSlideover component. Updated checkChanges function to handle claim conditions. +2/-0      beam.ts Extend Beam API to Handle Claim Conditions                              resources/js/api/beam.ts Extended the BeamApi to include claim conditions in the update beam data. +1/-0      UpdateBeam.ts Update GraphQL Mutation for Beam to Include Claim Conditions resources/js/graphql/mutation/beam/UpdateBeam.ts Modified the GraphQL mutation to support updating claim conditions. +2/-1      GetBeam.ts Enhance GraphQL Query to Fetch Claim Conditions for a Beam resources/js/graphql/query/beam/GetBeam.ts Added claim conditions to the GraphQL query for fetching single beam details. +4/-0      GetBeams.ts Update GraphQL Query to Include Claim Conditions in Beam List resources/js/graphql/query/beam/GetBeams.ts Included claim conditions in the GraphQL query for fetching multiple beams. +4/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (16d240b)

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	3, because the PR involves multiple files and integrates new functionality across the front-end and back-end, including Vue components and GraphQL queries. The changes are moderate in size and complexity, requiring a detailed review to ensure functionality and integration consistency.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The formatCondition function in DetailsBeamSlideover.vue assumes that all condition types will be in a format that benefits from replacing underscores with spaces. This might not always be appropriate depending on the actual data format or business requirements.
🔒 Security concerns	No

Code feedback:

---

relevant file	resources/js/components/slideovers/beam/DetailsBeamSlideover.vue
suggestion	Consider adding error handling for the formatCondition function to manage unexpected or malformed data gracefully. This could prevent UI crashes if the data does not meet expected patterns. [important]
relevant line	return `${type}: ${condition.value}`;

---

relevant file	resources/js/graphql/mutation/beam/UpdateBeam.ts
suggestion	Ensure that the ClaimConditionInputType in the GraphQL mutation is properly defined and handles all necessary validations, such as checking for null values or incorrect data types. This is crucial for maintaining data integrity. [important]
relevant line	export default `mutation UpdateBeam($code: String!, $name: String, $description: String, $image: String, $start: DateTime, $end: DateTime, $flags: [BeamFlagInputType!], $claimConditions: [ClaimConditionInputType]) {

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestions
Enhancement	Improve the uniqueness of keys in a list rendering. Consider using a more descriptive key for the v-for directive in the Chip component to ensure uniqueness beyond just the condition.type. This is especially important if the same type could appear with different values or in different contexts. resources/js/components/slideovers/beam/DetailsBeamSlideover.vue [59-63] <Chip v-for="condition in item.claimConditions" - :key="condition.type" + :key="`${condition.type}-${condition.value}`" :text="formatCondition(condition)" :closable="false" class="mr-2" />
Bug	Add null and undefined checks to prevent runtime errors. Add a check for item.claimConditions being non-null and non-undefined before checking its length to prevent potential runtime errors if item.claimConditions is undefined. resources/js/components/slideovers/beam/DetailsBeamSlideover.vue [56] -<div class="space-y-2 pt-4 pb-3" v-if="item.claimConditions.length"> +<div class="space-y-2 pt-4 pb-3" v-if="item.claimConditions && item.claimConditions.length">
Security	Sanitize input data to prevent security vulnerabilities. Ensure that updateBeamData.claimConditions is properly validated or sanitized before being used in the API call to prevent potential security issues such as injection attacks. resources/js/api/beam.ts [115] -claimConditions: updateBeamData.claimConditions, +claimConditions: sanitize(updateBeamData.claimConditions),
Best practice	Ensure necessary fields are marked as required in GraphQL mutations. Ensure that the claimConditions field in the GraphQL mutation definition is marked as required if the business logic expects every beam update to include claim conditions, similar to other fields in the mutation. resources/js/graphql/mutation/beam/UpdateBeam.ts [1] -$claimConditions: [ClaimConditionInputType] +$claimConditions: [ClaimConditionInputType!]
Maintainability	Use destructuring for cleaner and more readable code. Consider destructuring props.item for cleaner and more readable code when accessing multiple properties from props.item. resources/js/components/slideovers/beam/UpdateBeamSlideover.vue [155] -claimConditions: props.item?.claimConditions, +const { claimConditions } = props.item ?? {}; +... +claimConditions,