hotfix: clear promise call

[zlayine]

PR Type

Bug fix

---

Description

• Added calls to clearInitPromise after initPromise is awaited in various components to ensure the promise is cleared after initialization.
• Added clearInitPromise method in the store to facilitate clearing the initPromise.

---

Changes walkthrough 📝

Relevant files

Bug fix

12 files BeamsList.vue Clear initPromise after initialization in BeamsList            resources/js/components/beam/BeamsList.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      ClaimsList.vue Clear initPromise after initialization in ClaimsList          resources/js/components/beam/ClaimsList.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      BidsList.vue Clear initPromise after initialization in BidsList              resources/js/components/marketplace/BidsList.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      ListingsList.vue Clear initPromise after initialization in ListingsList      resources/js/components/marketplace/ListingsList.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      SalesList.vue Clear initPromise after initialization in SalesList            resources/js/components/marketplace/SalesList.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      Collections.vue Clear initPromise after initialization in Collections        resources/js/components/pages/Collections.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      FuelTanks.vue Clear initPromise after initialization in FuelTanks            resources/js/components/pages/FuelTanks.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      Tokens.vue Clear initPromise after initialization in Tokens                  resources/js/components/pages/Tokens.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      Transactions.vue Clear initPromise after initialization in Transactions      resources/js/components/pages/Transactions.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      Wallets.vue Clear initPromise after initialization in Wallets                resources/js/components/pages/Wallets.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      Login.vue Clear initPromise after initialization in Login                    resources/js/components/pages/auth/Login.vue Added call to clearInitPromise after initPromise is awaited. +1/-0      index.ts Add clearInitPromise method in store                                          resources/js/store/index.ts Added clearInitPromise method to clear the initPromise. +3/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Description updated to latest commit (86395bb)

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are repetitive across multiple files, focusing on a specific functionality (clearing promises). The logic is straightforward, and the modifications are consistent.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The clearInitPromise method sets initPromise to null without checking if it's already null or undefined, which could potentially lead to errors if the method is called multiple times in quick succession.
🔒 Security concerns	No

Code feedback:

---

relevant file	resources/js/store/index.ts
suggestion	Consider adding a check before setting initPromise to null to avoid potential issues if clearInitPromise is called multiple times. This can prevent unnecessary operations and potential errors in the application state management. [important]
relevant line	this.initPromise = null;

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible issue	Improve promise handling to ensure proper completion before clearing Consider using a more robust method to handle promise resolution or rejection before setting it to null. This ensures that any pending operations are properly completed or handled. resources/js/store/index.ts [284-286] clearInitPromise() { - this.initPromise = null; + if (this.initPromise) { + this.initPromise.then(() => { + this.initPromise = null; + }).catch((error) => { + console.error('Promise error:', error); + this.initPromise = null; + }); + } } Suggestion importance[1-10]: 9 Why: This suggestion addresses a potential issue where the promise might not be properly resolved or rejected before being set to null, which could lead to unhandled promise rejections or incomplete operations. It significantly improves the robustness of the code.	9
Possible bug	Modify the order of operations to prevent race conditions Ensure that clearInitPromise is called only after getBeams and other asynchronous operations are completed to avoid potential race conditions. resources/js/components/beam/BeamsList.vue [468-469] -useAppStore().clearInitPromise(); -getBeams(); +getBeams().then(() => { + useAppStore().clearInitPromise(); +}); Suggestion importance[1-10]: 8 Why: This suggestion addresses a potential race condition by ensuring that clearInitPromise is called only after getBeams completes. This change is crucial for preventing unexpected behavior due to asynchronous operations.	8
Enhancement	Add error handling for clearing the initialization promise Add error handling for the clearInitPromise method to gracefully handle any issues that might occur during the promise clearance. resources/js/components/pages/auth/Login.vue [157] -appStore.clearInitPromise(); +try { + appStore.clearInitPromise(); +} catch (error) { + console.error('Error clearing init promise:', error); +} Suggestion importance[1-10]: 7 Why: Adding error handling for clearInitPromise improves the code's robustness by ensuring that any issues during the promise clearance are caught and logged. This enhances the maintainability and reliability of the code.	7
Best practice	Check the state of initPromise before clearing to avoid unnecessary operations Consider verifying the state of initPromise before attempting to clear it, to ensure it's not already null or handled by another process. resources/js/components/pages/Wallets.vue [312] -useAppStore().clearInitPromise(); +if (useAppStore().initPromise) { + useAppStore().clearInitPromise(); +} Suggestion importance[1-10]: 6 Why: This suggestion is a best practice that ensures the initPromise is not unnecessarily cleared if it is already null or handled by another process. While it is a minor improvement, it adds a layer of safety to the code.	6