[PLA-1783] fix internal beams query

[zlayine]

PR Type

Bug fix

---

Description

• Added a call to appStore.fetchInternal() in BeamsList.vue before fetching beam codes to ensure internal configuration is fetched.
• Introduced a new method fetchInternal in the app store to fetch and update internal configuration.

---

Changes walkthrough 📝

Relevant files

Bug fix

BeamsList.vue Add internal fetch before beam codes retrieval                      resources/js/components/beam/BeamsList.vue Added a call to appStore.fetchInternal() before fetching beam codes. +1/-0      index.ts Add fetchInternal method to app store                                        resources/js/store/index.ts Added fetchInternal method to fetch internal configuration. Updated internal state based on the fetched configuration. +10/-0

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the PR involves a straightforward addition of a method and its usage in an existing function. The changes are localized and do not seem to involve complex logic or extensive modifications.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The fetchInternal method in index.ts sets this.internal to false in the catch block without rethrowing the error or handling it further. This could suppress important errors that should be visible to other parts of the application or logged for debugging purposes.
🔒 Security concerns	No

Code feedback:

---

relevant file	resources/js/store/index.ts
suggestion	Consider rethrowing the error or implementing error logging in the fetchInternal method's catch block. This will help in debugging and ensure that system administrators are aware of failures in fetching the internal configuration. [important]
relevant line	} catch {

---

relevant file	resources/js/components/beam/BeamsList.vue
suggestion	Add error handling for the await appStore.fetchInternal(); call in getBeamCodes. This will ensure that any issues during the fetching of internal configurations are properly managed and do not silently affect the application's behavior. [important]
relevant line	await appStore.fetchInternal();

---

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Possible bug	Check for undefined or null in url before making API call Ensure that the url property is checked for undefined or null before using it in ApiService.fetchInternalUrl(this.config.url!) to prevent runtime errors. resources/js/store/index.ts [202] -const internalConfig = await ApiService.fetchInternalUrl(this.config.url!); +if (this.config.url) { + const internalConfig = await ApiService.fetchInternalUrl(this.config.url); + if (internalConfig) { + this.internal = true; + } +} else { + console.warn("No URL configured for fetching internal settings."); + this.internal = false; +} Suggestion importance[1-10]: 10 Why: Ensuring that the url property is checked for undefined or null before using it in ApiService.fetchInternalUrl(this.config.url!) is essential to prevent runtime errors, making this a critical fix.	10
Possible issue	Add error handling for the fetchInternal method call Consider handling possible exceptions for the appStore.fetchInternal() method within the getBeamCodes function to ensure that any failures in fetching internal configurations do not affect the subsequent API calls. resources/js/components/beam/BeamsList.vue [320] -await appStore.fetchInternal(); +try { + await appStore.fetchInternal(); +} catch (error) { + console.error("Failed to fetch internal configurations:", error); +} Suggestion importance[1-10]: 9 Why: Adding error handling for the fetchInternal method call is crucial to ensure that any failures in fetching internal configurations do not affect subsequent API calls. This improves the robustness of the code.	9
Best practice	Ensure isLoading.value is reset after operations complete It's a good practice to reset isLoading.value to false after all asynchronous operations are completed to ensure the UI reflects the correct loading state. resources/js/components/beam/BeamsList.vue [322-323] -const res = await BeamApi.getBeams({ - ...formatData(searchInput.value ? { codes: [searchInput.value] } : {}), +try { + const res = await BeamApi.getBeams({ + ...formatData(searchInput.value ? { codes: [searchInput.value] } : {}), + // Handle success +} catch (error) { + // Handle error +} finally { + isLoading.value = false; +} Suggestion importance[1-10]: 8 Why: Resetting isLoading.value to false after all asynchronous operations ensures the UI reflects the correct loading state, which is a good practice for better user experience.	8
Enhancement	Handle undefined internalConfig more explicitly Consider setting a default value or handling the case when internalConfig is undefined to avoid potential issues where this.internal remains unchanged if the API call fails silently. resources/js/store/index.ts [204-205] if (internalConfig) { this.internal = true; +} else { + this.internal = false; + console.warn("Failed to fetch or parse internal configuration."); } Suggestion importance[1-10]: 7 Why: Handling the case when internalConfig is undefined adds clarity and ensures that this.internal is set correctly, improving code reliability and maintainability.	7