[PLA-1824] fix token creation

[zlayine]

PR Type

Bug fix

---

Description

• Fixed the handling of the media attribute in both CreateCollection.vue and CreateToken.vue to ensure it is properly stringified or set to an empty string.
• Corrected the merging of simpleAttributes and attributes in both CreateCollection.vue and CreateToken.vue to avoid nested arrays.

---

Changes walkthrough 📝

Relevant files

Bug fix

CreateCollection.vue Fix media attribute handling and attributes merging            resources/js/components/pages/create/CreateCollection.vue Fixed the handling of the media attribute to ensure it is properly stringified or set to an empty string. Corrected the merging of simpleAttributes and attributes to avoid nested arrays. +2/-2      CreateToken.vue Fix media attribute handling and attributes merging            resources/js/components/pages/create/CreateToken.vue Fixed the handling of the media attribute to ensure it is properly stringified or set to an empty string. Corrected the merging of simpleAttributes and attributes to avoid nested arrays. +12/-7

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[github-actions]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review [1-5]	2
🧪 Relevant tests	No
🔒 Security concerns	No
⚡ Key issues to review	Possible Bug: The changes in the handling of the media attribute in both CreateCollection.vue and CreateToken.vue need to ensure that the JSON.stringify operation does not introduce any issues when the media or imageUrl values are empty or not in the expected format.
	Data Integrity: The modification in the merging of simpleAttributes and attributes to avoid nested arrays should be carefully reviewed to ensure that it does not affect the existing data structure and flow, especially in edge cases where attributes might be missing or malformed.

[github-actions]

PR Code Suggestions ✨

Category	Suggestion	Score
Security	Sanitize imageType.value to enhance security Ensure that imageType.value is properly sanitized or validated before using it in the JSON object to prevent potential security risks such as XSS if imageType.value is user-controlled. resources/js/components/pages/create/CreateToken.vue [405] -type: imageType.value, +type: sanitize(imageType.value), Suggestion importance[1-10]: 10 Why: Ensuring that imageType.value is sanitized is essential for preventing potential security risks such as XSS, especially if imageType.value is user-controlled. This is a critical security enhancement.	10
Possible bug	Add a null check for the media variable to prevent runtime errors Consider checking for both null and undefined values of media before using its length property to avoid potential runtime errors if media is not defined. resources/js/components/pages/create/CreateCollection.vue [442] -value: media.length ? JSON.stringify(media) : '', +value: media && media.length ? JSON.stringify(media) : '', Suggestion importance[1-10]: 9 Why: Adding a null check for media is crucial to prevent potential runtime errors if media is not defined. This is a significant improvement for code robustness.	9
Enhancement	Standardize attribute filtering across components To ensure consistent data handling, consider using a similar approach to handling empty attributes as in CreateToken.vue, where both key and value are checked. resources/js/components/pages/create/CreateCollection.vue [502] -attributes: [...simpleAttributes(), ...attributes.value.filter((a) => a.key !== '' && a.value !== '')], +attributes: [...simpleAttributes(), ...attributes.value.filter((a) => a.key && a.value)], Suggestion importance[1-10]: 8 Why: Using a consistent approach to handle empty attributes across components enhances code consistency and reliability. This is a valuable improvement for maintainability and data handling.	8
Maintainability	Refactor media JSON creation into a helper function To improve code readability and maintainability, consider creating a helper function to generate the JSON object for the media attribute. resources/js/components/pages/create/CreateToken.vue [401-408] -value: imageUrl.value - ? JSON.stringify([ - { - url: imageUrl.value, - type: imageType.value, - }, - ]) - : '', +value: formatMedia(imageUrl.value, imageType.value), Suggestion importance[1-10]: 7 Why: Creating a helper function for generating the JSON object for the media attribute improves code readability and maintainability. This is a good practice for cleaner and more modular code.	7