You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration Consistency: Ensure that the new pint.json configuration aligns with the project's coding standards and that all necessary rules are included as per the removed .php-cs-fixer.php.
Dependency Update: Verify that the new dependency laravel/pint is compatible with other project dependencies and the Laravel 11 framework.
Broaden the PHP version compatibility to include more users
Consider specifying a broader range of compatible PHP versions if possible. Restricting to "^8.2" might limit users who are on slightly older but still supported versions of PHP.
Why: Broadening the PHP version compatibility can help include users who are on slightly older but still supported versions, increasing the usability of the package.
9
Maintainability
Ensure continuity of code style checks by adding back or replacing necessary packages
Add a replacement for the removed 'friendsofphp/php-cs-fixer' in 'require-dev' to maintain code style checks or clarify the transition strategy to 'laravel/pint'.
Why: Adding back 'friendsofphp/php-cs-fixer' or clarifying the transition to 'laravel/pint' ensures that code style checks remain consistent and maintainable.
8
Best practice
Add a 'lint' script for consistency and clarity in usage
Consider adding a script for 'lint' that uses 'laravel/pint' for consistency with typical Laravel project setups.
Why: Reviewing and potentially adjusting the 'no_unreachable_default_argument_value' rule can prevent unintended conflicts, though it may not be necessary for all projects.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
enhancement, configuration changes
Description
composer.json
to require PHP "^8.2" and replacedfriendsofphp/php-cs-fixer
withlaravel/pint
.composer.json
forfix
usinglaravel/pint
.pint.json
for Laravel Pint with extensive rules.Changes walkthrough 📝
.php-cs-fixer.php
Remove PHP CS Fixer configuration file
.php-cs-fixer.php
pint.json
Add Laravel Pint configuration file
pint.json
composer.json
Update dependencies and scripts in composer.json
composer.json
friendsofphp/php-cs-fixer
withlaravel/pint
.fix
usinglaravel/pint
.