-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLA-2020] wallet list sign #165
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Type
enhancement, bug_fix
Description
walletAccounts
to filter enabled accounts and updating components to use this property.WalletAppItem
for managing wallet accounts, including enabling and disabling accounts.disabledAccounts
state and methods to manage account enable/disable status.Changes walkthrough 📝
SignTransaction.vue
Update account handling with computed wallet accounts
resources/js/components/SignTransaction.vue
connectionStore.accounts
withwalletAccounts
for accountiteration.
walletAccounts
to filter enabled accounts.walletAccounts
.SettingsWalletApp.vue
Refactor wallet app settings with loading and item component
resources/js/components/pages/SettingsWalletApp.vue
WalletAppItem
component.WalletAppItem.vue
Add WalletAppItem component for account management
resources/js/components/pages/WalletAppItem.vue
connection.ts
Enhance connection store with account enable/disable functionality
resources/js/store/connection.ts
disabledAccounts
to store state and persistence.types.interface.ts
Update ConnectionState interface with disabled accounts
resources/js/types/types.interface.ts
disabledAccounts
toConnectionState
interface.WalletConnectButton.vue
Ensure wallet accounts default to empty array
resources/js/components/WalletConnectButton.vue
walletAccounts
to prevent undefinederrors.
CreateCollection.vue
Fix media array initialization in collection creation
resources/js/components/pages/create/CreateCollection.vue
not present.