[PLA-1454] [PLA-1479] add revoke confirmation

[zlayine]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Adding a confirmation modal for revoking API tokens
• 📝 PR summary: This PR introduces a confirmation modal when a user attempts to revoke an API token. The modal is reusable and has been integrated into the Settings and RetryTransactionSlideover components. The text within the modal is dynamic, allowing it to be used in different contexts.
• 📌 Type of PR: Enhancement
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and limited to a few files. However, the lack of tests increases the review effort slightly.
• 🔒 Security concerns: No security concerns found

PR Feedback

• 💡 General suggestions: The PR is well-structured and the changes are clear. However, it would be beneficial to add tests to ensure the new functionality works as expected and to prevent potential regressions in the future.

• 🤖 Code feedback:

  • relevant file: resources/js/components/ConfirmModal.vue
    suggestion: Consider adding prop validation for 'title' and 'description' props to ensure they are always strings. This can help prevent potential bugs and make the code more robust. [medium]
    relevant line: defineProps<{ isOpen: boolean; title: string; description: string }>();

  • relevant file: resources/js/components/pages/Settings.vue
    suggestion: It's good practice to reset all state when a modal is closed, not just when the action is confirmed. Consider moving the reset of 'confirmModalName' to the @closed event handler. [medium]
    relevant line: @closed="confirmModal = false"

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.