[PLA-1465] [PLA-1059] [PLA-1478] fix navbar

[zlayine]

No description provided.

[github-actions]

PR Analysis

• 🎯 Main theme: Fixing various issues in the navbar and other components
• 📝 PR summary: This PR addresses several issues in the navbar and other components. It adds a condition for the mobile menu button in the navbar, fixes the royalty percentage display, and adds a link to the transaction hash in the transaction details.
• 📌 Type of PR: Bug fix
• 🧪 Relevant tests added: No
• ⏱️ Estimated effort to review [1-5]: 2, because the changes are straightforward and there are no complex logic changes.
• 🔒 Security concerns: Yes, because the PR introduces a new function that generates a URL based on user input. If not properly sanitized, this could lead to potential security issues.

PR Feedback

• 💡 General suggestions: The PR seems to be addressing multiple issues at once. It would be better to separate these into individual PRs for each issue. This would make the changes easier to review and understand.

• 🤖 Code feedback:

  • relevant file: resources/js/components/UserNavbar.vue
    suggestion: Consider adding a comment to explain the condition for the DisclosureButton visibility. This would make the code more readable and maintainable. [medium]
    relevant line: v-if="(appStore.isMultiTenant && appStore.hasValidConfig) || !appStore.isMultiTenant"

  • relevant file: resources/js/components/slideovers/collection/DetailsCollectionSlideover.vue
    suggestion: Ensure that the royalty percentage is being calculated correctly after the change. If the percentage was previously multiplied by 100, removing this could cause issues. [important]
    relevant line:

    {{ Royalty.getRoyaltyPercentage(item) }}%

  • relevant file: resources/js/components/slideovers/common/DetailsTransactionSlideover.vue
    suggestion: Make sure that the getSubscanUrl function is properly sanitizing the transaction hash to prevent potential security issues. [important]
    relevant line: :href="getSubscanUrl(transaction.transactionHash)"

How to use

Instructions

To invoke the PR-Agent, add a comment using one of the following commands:
/review: Request a review of your Pull Request.
/describe: Update the PR title and description based on the contents of the PR.
/improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
/ask <QUESTION>: Ask a question about the PR.
/update_changelog: Update the changelog based on the PR's contents.
/add_docs: Generate docstring for new components introduced in the PR.
/generate_labels: Generate labels for the PR based on the PR's contents.
see the tools guide for more details.

To edit any configuration parameter from the configuration.toml, add --config_path=new_value.
For example: /review --pr_reviewer.extra_instructions="focus on the file: ..."
To list the possible configuration parameters, add a /config comment.