Fix EOS-S3 build on latest F4PGA #1799
Conversation
F4PGA uses new clock names which differs from names used in QORC SDK. Signed-off-by: Artur Kowalski <artur.kowalski@3mdeb.com>
Signed-off-by: Artur Kowalski <artur.kowalski@3mdeb.com>
This requires patched F4PGA: chipsalliance/f4pga#666 Signed-off-by: Artur Kowalski <artur.kowalski@3mdeb.com>
arturkow2
force-pushed
the
s3_fix_f4pga_toolchain
branch
from
d3448ed to
c0071c1
Compare
| "EOS3FF512-PDN64": { | ||
| "default_target": "bitstream", | ||
| "dependencies": { | ||
| "build_dir": "build", |
There was a problem hiding this comment.
By setting build_dir to build directory all output files are located in this sub-dir instead of directly into gateware (as for all toolchains). But by using self._build_dir instead of build prepare_cmd will override .sdc file: what do you think about renaming xxx.sdc (in build_timing_constraints) by xxx_in.sdc ?
| if subprocess.call(make_cmd + ["bitstream_openocd"]) != 0: | ||
| raise OSError("Error occured during QuickLogic Symbiflow's script execution.") | ||
|
|
||
| if subprocess.call(make_cmd + ["bitstream_jlink"]) != 0: | ||
| raise OSError("Error occured during QuickLogic Symbiflow's script execution.") |
There was a problem hiding this comment.
These two commands produces only bitstream/rules for openOCD and jlink so we lost ability to obtain .bit.bin and .bit.h files: it's required to add bitstream_bitheader and bitstream_binary too.
What do you think about using a dict to iterate on all 4 targets and improving error message with target name?
|
Looks good, just two small remarks. Unfortunately by applying another PR and a modification there is a conflict. If you prefer I could apply by myself this PR and, at the same time, addressing the two comments. |
|
Applied. Thanks @arturkow2 |
No description provided.