Skip to content

Commit

Permalink
RFC 0128: Use correct [[targets.distros]] schema
Browse files Browse the repository at this point in the history
Updates RFC 0128 to use the correct `[[targets.distros]]` schema as defined
already in the spec:
https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml

I've not added an `## Amended` section, since:
1. The RFC has only just merged (this is effectively a review comment
   that missed the merge by a day)
2. The parts of the RFC being fixed are existing concepts already in the spec,
   rather than design decisions relating to the purpose of the RFC itself.

Fixes:
buildpacks#295 (comment)
Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
  • Loading branch information
edmorley authored and enrichman committed Aug 8, 2024
1 parent 571667c commit 2d7905b
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions text/0128-multiarch-builders-and-package.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ arch = "arm64"
os = "windows"
arch = "amd64"

[[targets.distributions]]
[[targets.distros]]
name = "windows"
versions = ["10.0.20348.1970"]
version = "10.0.20348.1970"

# Stacks (deprecated) the buildpack will work with
[[stacks]]
Expand Down Expand Up @@ -286,9 +286,9 @@ variant = "<architecture variant>"
# optional
path = "<path to look for the binaries if the folder structure convention is not followed>"

[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"
```
- When `more than 1 target is defined`
- When `--publish` is specified
Expand Down Expand Up @@ -681,9 +681,9 @@ arch = "arm64"
os = "windows"
arch = "amd64"
[[targets.distributions]]
[[targets.distros]]
name = "windows"
versions = ["10.0.20348.1970"]
version = "10.0.20348.1970"
# Stacks (deprecated) the buildpack will work with
[[stacks]]
Expand Down Expand Up @@ -763,9 +763,9 @@ os = "<operating system>"
arch = "<system architecture>"
variant = "<architecture variant>"
[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"
[[dependencies]]
uri = "<A URL or path to an archive, a packaged buildpack (saved as a .cnb file), or a directory. If path is relative, it must be relative to the package.toml>"
Expand Down Expand Up @@ -843,9 +843,9 @@ image = "<build image reference>"
os = "<operating system>"
arch = "<system architecture>"
variant = "<architecture variant>"
[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"
```
- Add a new `--target` optional flag with format `[os][/arch][/variant]:[name@version]` to create a builder for a
particular target, this will help end-users to specify the platform for which they want to create single OCI artifact.
Expand Down

0 comments on commit 2d7905b

Please sign in to comment.