This repository was archived by the owner on Sep 21, 2019. It is now read-only.
Switch to Websockets #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommunication with the ensime server instead of a worker.
|
wow, nice! BTW, you've still not added yourself here http://ensime.github.io/editors/ We'd love to see this project represented there. |
Contributor
Author
|
Will do as soon as I've it running with the newest ENSIME version - we'll start working on that this afternoon. |
Contributor
Author
|
tweet and let me know and I'll get some retweets going |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely switch to websockets for the communication with ENSIME. We no longer need the HTTP RPC protocol.
To do that we switched from calling ENSIME from a worker towards a ensime-connector (c9-)plugin. This supports using the stdin of the ensime-runner process so we can send the requests there. Responses and events are (as before) read from the stdout of said process.