This repository was archived by the owner on Sep 21, 2019. It is now read-only.
Fix regression in non-Syntastic typecheck error highlighting #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from #328 where Vim's string result to the Syntastic feature detection wasn't properly cast to Boolean, and escaping was doubled after changing match pattern to a Python raw string. Closes #339.
|
@ches I tried this and it works for me, thanks for the quick fix! |
Contributor
|
Working for me as well. LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #328 where I didn't properly cast Vim's string
'0'result from the Syntastic feature detection to Boolean, and escaping was doubled when changing highlight match pattern to a Python raw string.I believe this fixes the issue—the highlighting only works for me in GUI, not on console, but I think that's something with my setup or something that wasn't changed by #328 anyway. This feature is still kinda janky altogether, I made notes in #328 about the logic for the highlighting group customization seemingly not making sense, etc.
It'd be good to add a test or two but it would be a bit hairy to do, so I'll save that until the further
EditorAPI improvements, and maybe we can give this feature a little love overall.Closes #339. @gigiigig you might be happy with Syntastic now, but if you're able to try this with it disabled and confirm if it restores the behavior you had before, that'd be awesome.