This repository was archived by the owner on Sep 21, 2019. It is now read-only.
Work around a startup error on Vim < 7.4 #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #369, refs #368 (1b32e85) There are other uses of Vim 7.4+ Python API in our code, this does not attempt to fix all of them. This just avoids a particularly bad failure mode during Vim startup.
This was referenced Jan 13, 2017
ktonga
approved these changes
Jan 13, 2017
Contributor
|
Hey @ches why isn't this PR merged yet? Shall we close it in favor of discarding <7.4 support? |
Contributor
Author
|
Sorry, I must have missed the approval, I've been preoccupied in the past few weeks. I'd say let's take this since it does solve a lousy failure mode right now, and #371 remains to track imposing the version restriction. |
Contributor
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369, refs #368 (1b32e85)
Yeah, I could have left only the
vim.commandversion of the code here and had compatibility with old and new, but there are other uses of Vim 7.4+ Python API in our code and this change does not attempt to fix all of them now. This just avoids a particularly poor failure mode during Vim startup.I think we ought to officially make versions this old unsupported: detect the version and gracefully reject loading the plugin, informing the user. Serious day-to-day work on Scala projects where you'd want IDE features suggests a workstation-class environment IMO, so ensime-vim ought to be free to make assumptions accordingly. ensime-emacs is rather stringent about its requirements. Ubuntu 12.04 (as in #369) goes end-of-life in about 3 months, so it's barely server-class anymore. A possible policy could be to support the last two Vim minor versions (i.e. 8.0 and 7.4). We can discuss this more on a new issue.