Skip to content

Commit

Permalink
Increase timeout and vite version (#11492)
Browse files Browse the repository at this point in the history
1. The electron test hit timeouts from time to time, probably because of slow response from the engine: increased timeout.
2. Unify vite version across packages.
  • Loading branch information
farmaazon authored Nov 8, 2024
1 parent 014a2a7 commit 86c5946
Show file tree
Hide file tree
Showing 4 changed files with 10,491 additions and 5,583 deletions.
2 changes: 1 addition & 1 deletion app/ide-desktop/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"fast-glob": "^3.2.12",
"portfinder": "^1.0.32",
"tsx": "^4.7.1",
"vite": "^5.3.5",
"vite": "^5.4.10",
"playwright": "^1.45.0"
},
"//": [
Expand Down
2 changes: 1 addition & 1 deletion app/ide-desktop/client/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default defineConfig({
testDir: './tests',
forbidOnly: !!process.env.CI,
workers: 1,
timeout: 60000,
timeout: 120000,
reportSlowTests: { max: 5, threshold: 60000 },
globalSetup: './tests/setup.ts',
expect: {
Expand Down
4 changes: 2 additions & 2 deletions app/ide-desktop/client/tests/createNewProject.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ electronTest('Create new project', async page => {
await expect(page.locator('.GraphNode')).toHaveCount(1, { timeout: 60000 })

// We see the node type and visualization, so the engine is running the program
await expect(page.locator('.node-type')).toHaveText('Table')
await expect(page.locator('.TableVisualization')).toBeVisible()
await expect(page.locator('.node-type')).toHaveText('Table', { timeout: 30000 })
await expect(page.locator('.TableVisualization')).toBeVisible({ timeout: 30000 })
await expect(page.locator('.TableVisualization')).toContainText('Welcome To Enso!')

// We can add new node and see suggestions.
Expand Down
Loading

0 comments on commit 86c5946

Please sign in to comment.