Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pending node status #7435

Closed
Tracked by #7125
farmaazon opened this issue Jul 31, 2023 · 3 comments · Fixed by #7541
Closed
Tracked by #7125

Pending node status #7435

farmaazon opened this issue Jul 31, 2023 · 3 comments · Fixed by #7541
Assignees
@kazcw
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Jul 31, 2023 •
edited
Loading

The IDE may receive the "Pending" status for nodes from the engine; it is sent in executionContext/expressionUpdates messages and stored in ComputedValueInfoRegistry inside the execution context.

In this task, this informatino should be propagated to view, and "pending" nodes should be displayed as in design (they have 50% their normal opacity):

Image
@farmaazon farmaazon mentioned this issue Jul 31, 2023
Closed
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jul 31, 2023
@farmaazon farmaazon added p-high Should be completed in the next sprint g-graph-editor d-easy Difficulty: little prior knowledge required labels Jul 31, 2023
@farmaazon farmaazon added this to the Beta Release milestone Jul 31, 2023
@enso-bot enso-bot bot mentioned this issue Aug 8, 2023
Closed
@kazcw kazcw mentioned this issue Aug 10, 2023
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Aug 10, 2023

Keziah Wesley reports a new STANDUP for yesterday (2023-08-08):

Progress: Applying review of #7197. Started implementing pending node status. It should be finished by 2023-08-09.

Next Day: Next day I will be working on the #7435 task. Finish pending node status.

@farmaazon farmaazon moved this from 📤 Backlog to 🔧 Implementation in Issues Board Aug 10, 2023
@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Aug 10, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 11, 2023

Keziah Wesley reports a new STANDUP for yesterday (2023-08-09):

Progress: Finished implementing pending nodes It should be finished by 2023-08-09.

Next Day: Next day I will be working on the #7255 task. Start on context recovery.

@kazcw kazcw linked a pull request Aug 11, 2023 that will close this issue
Pending nodes #7541
Merged
5 tasks
@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Aug 14, 2023
@vitvakatu
Copy link
Contributor

We also want to display some indication that the node is currently evaluating. I will create a separate task for that.

@vitvakatu vitvakatu mentioned this issue Aug 14, 2023
Open
@vitvakatu vitvakatu moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Aug 14, 2023
@vitvakatu vitvakatu moved this from 🟢 Accepted to 🌟 Q/A review in Issues Board Aug 14, 2023
@mergify mergify bot closed this as completed in #7541 Aug 17, 2023
mergify bot pushed a commit that referenced this issue Aug 17, 2023
@kazcw
Pending nodes (#7541)
d15b3db 
Implement *pending* node status (#7435).

Design reference:
https://user-images.githubusercontent.com/3919101/257222729-838cfe84-7447-40a3-8aa1-5424de66b0b7.png

Demo:
[vokoscreenNG-2023-08-09_22-29-13.webm](https://github.com/enso-org/enso/assets/1047859/2906599d-920f-44df-9c0f-c617ebbd5ecc)

# Important Notes
- Reduce alpha value of node backgrounds, label widgets, and method widget icons while the engine reports "pending" state.
- Use FRP and themes for method widgets.
- Update node input area to use `define_endpoints_2`.
- Also remove some code supporting the disused *profiling mode*.
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Aug 17, 2023
@vitvakatu vitvakatu moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kazcw kazcw

Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Pending nodes enso-org/enso
3 participants
@kazcw @farmaazon @vitvakatu