-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending nodes #7541
Pending nodes #7541
Conversation
759055d
to
77ff9cc
Compare
77ff9cc
to
c39803a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like to have widget's code checked by @Frizi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, just some minor stylistic nits.
app/gui/view/graph-editor/src/component/node/input/widget/label.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/node/input/widget/label.rs
Outdated
Show resolved
Hide resolved
app/gui/view/graph-editor/src/component/node/input/widget/method.rs
Outdated
Show resolved
Hide resolved
I've adjusted this at the input port (target attachment) ends, however I can't make the output edges look right by changing their end points, since a flat-ended line can't meet a rounded node exactly. Our current rendering system cannot reconcile performance (minimizing shader count) with transparency. When we eventually switch to Z-buffer compositing, we can draw this correctly. |
Pull Request Description
Implement pending node status (#7435).
Design reference:
https://user-images.githubusercontent.com/3919101/257222729-838cfe84-7447-40a3-8aa1-5424de66b0b7.png
Demo:
vokoscreenNG-2023-08-09_22-29-13.webm
Important Notes
define_endpoints_2
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.