Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltips #10039

Merged
merged 3 commits into from
May 23, 2024
Merged

Tooltips #10039

merged 3 commits into from
May 23, 2024

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

First solution for #9828, just using HTML title attribute.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@farmaazon farmaazon added CI: No changelog needed Do not require a changelog entry for this PR. -gui labels May 22, 2024
@farmaazon farmaazon self-assigned this May 22, 2024
kazcw
kazcw approved these changes May 22, 2024
View reviewed changes
app/gui2/src/components/CircularMenu.vue Outdated
@click.stop="showColorPicker = true"
/>
<SvgButton
v-if="isFullMenuVisible"
name="trash2"
class="slot4"
:alt="`Delete component`"
title="`Delete`"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra quotes

@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label May 23, 2024
@mergify mergify bot merged commit a0a6f8c into develop May 23, 2024
35 checks passed
@mergify mergify bot deleted the wip/farmaazon/title-tooltips branch May 23, 2024 07:52
@farmaazon farmaazon linked an issue May 28, 2024 that may be closed by this pull request
Add Tooltips #9828
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw approved these changes

@Frizi Frizi Frizi approved these changes

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@farmaazon farmaazon

Labels
-gui CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Tooltips
3 participants
@farmaazon @Frizi @kazcw