Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks following Steve's testings #10042

Merged
merged 8 commits into from
May 27, 2024
Merged

Some tweaks following Steve's testings #10042

merged 8 commits into from
May 27, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented May 22, 2024

Pull Request Description

  • Add ranged number widget to at and get.
  • Add defaults to at and get picking the first item.
  • PRIVATE on various Excel_Workbook methods. It still works like a connection but not shown in CB.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley changed the title wip/jd/fixes-20240522 Some tweaks following Steve's testings May 24, 2024
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label May 24, 2024
@jdunkerley jdunkerley marked this pull request as ready for review May 24, 2024 13:45
@@ -214,7 +217,7 @@ type Date_Range
(Date.new 2021 05 07).up_to (Date.new 2021 05 10) . to_vector
to_vector : Vector Date
to_vector self =
proxy = Array_Proxy.new self.length self.at
proxy = Array_Proxy.new self.length (self.at _)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change do? Naively, I thought self.at == x-> self.at x == self.at _.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the index argument of at got a default, calling self.at will force all default arguments and thus will return the first element, not the lambda. The equation above holds if there are no default arguments.

Btw.

Suggested change
proxy = Array_Proxy.new self.length (self.at _)
proxy = Array_Proxy.new self.length (self.at ...)

would probably work as well

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label May 27, 2024
@mergify mergify bot merged commit d8059fd into develop May 27, 2024
37 checks passed
@mergify mergify bot deleted the wip/jd/fixes-20240522 branch May 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants