Adjust Refresh Interval in Assets table #10775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrFlashAccount
added
CI: No changelog needed
MrFlashAccount
force-pushed
the
wip/sergeigarin/adjust-refetch
branch
3 times, most recently
from
afa0112
to
8eccd67
Compare
MrFlashAccount
requested review from
PabloBuchu,
indiv0,
somebody1234,
Frizi,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
MrFlashAccount
force-pushed
the
wip/sergeigarin/adjust-refetch
branch
2 times, most recently
from
4559353
to
07b5578
Compare
| if (listDirectoryQuery?.state.data) { | ||
| listDirectoryQuery.setData({ | ||
| ...listDirectoryQuery.state.data, | ||
| children: [...listDirectoryQuery.state.data.children, ...assets], |
There was a problem hiding this comment.
optional, re: ordering -
see https://github.com/enso-org/enso/pull/10775/files?w=1#diff-0e343617d95ffe3a6da1c565633d686bb84ec06614b5bd8b4833c56d78d1b198L249-L283 for how it was previously done
somebody1234
approved these changes
Aug 14, 2024
MrFlashAccount
force-pushed
the
wip/sergeigarin/adjust-refetch
branch
from
7187ac2
to
aabd0a3
Compare
MrFlashAccount
added
the
CI: Ready to merge
MrFlashAccount
force-pushed
the
wip/sergeigarin/adjust-refetch
branch
from
da2ea5a
to
5da59bd
Compare
# Conflicts: # app/dashboard/src/App.tsx # app/dashboard/src/layouts/AssetsTable.tsx # app/dashboard/src/layouts/DriveBar.tsx
MrFlashAccount
force-pushed
the
wip/sergeigarin/adjust-refetch
branch
from
58e9ed5
to
a9d6989
Compare
# Conflicts: # app/dashboard/src/App.tsx # app/dashboard/src/components/Devtools/EnsoDevtools.tsx # app/dashboard/src/components/dashboard/AssetRow.tsx # app/dashboard/src/layouts/AssetsTable.tsx
# Conflicts: # app/dashboard/src/components/AriaComponents/Form/Form.tsx # app/dashboard/src/components/AriaComponents/Form/components/Field.tsx # app/dashboard/src/components/AriaComponents/Form/components/types.ts # app/dashboard/src/components/AriaComponents/Form/components/useForm.ts # app/dashboard/src/components/AriaComponents/Form/types.ts
|
@MrFlashAccount I dont think the refreshing is enabled by default in electron? we should do that. lemme know once it is done |
PabloBuchu
approved these changes
Sep 3, 2024
|
I think its fine now ✅ |
# Conflicts: # app/dashboard/src/components/dashboard/AssetRow.tsx # app/dashboard/src/layouts/AssetsTable.tsx
jdunkerley
pushed a commit
that referenced
this pull request
Sep 9, 2024
(cherry picked from commit 77183e5)
jdunkerley
pushed a commit
that referenced
this pull request
Sep 10, 2024
(cherry picked from commit 77183e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.