Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard UX improvements #10868

Merged
merged 52 commits into from
Aug 29, 2024
Merged

Dashboard UX improvements #10868

merged 52 commits into from
Aug 29, 2024

Conversation

somebody1234
Copy link
Contributor

@somebody1234 somebody1234 commented Aug 22, 2024

Pull Request Description

  • Fix dropdown focus issues
    • Keyboard navigation to/from dropdowns and between options
    • Mouse focus to/from dropdowns (there is no mouse navigation between options)
  • Use new inputs in "new secret" modal
  • Simplify form types
  • Switch activity log date filters to use DatePicker which is a wrapper around a react-aria-components input
    • Update react-aria-components
  • Prevent Navigator2D from handling event if it has already been defaultPrevented
  • Switch from * imports to {} imports for various files
  • Switch assets table row headings to use new components

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

Copy link
Contributor

@vitvakatu vitvakatu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GUI files

Copy link
Contributor

@kazcw kazcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed only common code

@@ -66,6 +66,19 @@ export function unsafeEntries<T extends object>(
return Object.entries(object)
}

// =====================
// === unsafeEntries ===
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong header

@PabloBuchu
Copy link
Contributor

QA ✅

@somebody1234 somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Aug 28, 2024
@mergify mergify bot merged commit 848e869 into develop Aug 29, 2024
32 of 33 checks passed
@mergify mergify bot deleted the wip/sb/rac-dropdown branch August 29, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge g-dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants