Ensure clients get write capability #10872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Ydoc requests to open file and encounters a timeout, it will attempt to retry the request. At least that's the behaviour since #10787. Unfortunately, the write lock on the file might be already held and identified by the client id and actor reference. The latter is always determined by the request and therefore spurious. The same client should always be given the same capability, even on retries.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
4e6,
JaroslavTulach and
Akirathan
as code owners
4e6
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When Ydoc requests to open file and encounters a timeout, it will attempt to retry the request. At least that's the behaviour since
#10787.
Unfortunately, the write lock on the file might be already held and identified by the client id and actor reference. The latter is always determined by the request and therefore spurious. The same client should always be given the same capability, even on retries.
Related to #10579.